Skip to content

Base: Use fewer external commands in default shell completions #26007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2025
Merged

Base: Use fewer external commands in default shell completions #26007

merged 1 commit into from
Jun 25, 2025

Conversation

alimpfard
Copy link
Member

fork/exec is very slow in emulation mode, avoid doing so many of them.

@alimpfard
Base: Use fewer external commands in default shell completions
a3395ac 
fork/exec is very slow in emulation mode, avoid doing so many of them.
@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 23, 2025
spholz
spholz reviewed Jun 25, 2025
View reviewed changes
Copy link
Member

@spholz spholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This makes tab completing cd a lot faster in riscv64 QEMU with -accel tcg.

@spholz spholz merged commit 15a14bf into SerenityOS:master Jun 25, 2025
13 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spholz spholz spholz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alimpfard @spholz