Skip to content

fix: fix organic food/fertilizer check #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Apr 12, 2025

Description

Installing a resource pack by modifying item-models.yml on the server will interfere with the item comparison for organic food/fertilizers.

Proposed changes

Change the item comparison to SlimefunItem instance type check for organic food/fertilizers.

Related Issues (if applicable)

#3446 but this PR does not fully fix the issue.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner April 12, 2025 21:25
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Apr 12, 2025
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: a685de0

https://preview-builds.walshy.dev/download/Slimefun/4307/a685de00

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Member

@TheBusyBiscuit TheBusyBiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants