Skip to content

Conversation

@y-yagi
Copy link
Contributor

@y-yagi y-yagi commented May 7, 2020

This patch added a callback that execute only when user locked. This callback useful for run something actions(e.g. send notifications to admin) when user locked.

@y-yagi y-yagi force-pushed the add_after_login_lock branch from c43ff87 to e5a4559 Compare May 7, 2020 06:26
@y-yagi y-yagi force-pushed the add_after_login_lock branch from e5a4559 to 3fd7980 Compare February 21, 2021 23:45
@y-yagi
Copy link
Contributor Author

y-yagi commented Feb 21, 2021

Any feedback?

@joshbuker joshbuker added the to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed. label May 27, 2021
@joshbuker
Copy link
Member

@y-yagi Thanks Yagi, I'll get this into v1. Are there any other callbacks that you've found yourself wishing Sorcery provided?

@y-yagi
Copy link
Contributor Author

y-yagi commented May 28, 2021

Thanks for the reply! This is the only callback that we need.

@willnet
Copy link
Member

willnet commented Oct 31, 2025

@y-yagi I think the implementation looks good. Please resolve the conflicts and update the tests to follow the current style. (Right now, controller specs are written to avoid using mocks as much as possible. ref: #390 )

This patch added a callback that execute only when user locked.
This callback useful for run something actions(e.g. send notifications
to admin) when user locked.
@y-yagi y-yagi force-pushed the add_after_login_lock branch from 3fd7980 to cf4af83 Compare November 7, 2025 22:12
@y-yagi
Copy link
Contributor Author

y-yagi commented Nov 7, 2025

@willnet Hi, I resolved the conflict.

@willnet willnet merged commit 61899c1 into Sorcery:master Nov 10, 2025
14 checks passed
@willnet
Copy link
Member

willnet commented Nov 10, 2025

@y-yagi thanks!

@y-yagi y-yagi deleted the add_after_login_lock branch November 10, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants