Skip to content

[BugFix] Fix window output partition propery (backport #60344) #60573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: branch-3.4
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 3, 2025

Why I'm doing:

For SQL:

 select *, LAG(lo_extendedprice) OVER (PARTITION BY lo_orderkey, lo_custkey ORDER BY lo_commitdate) AS bug_1 from (
    select lo_orderkey, lo_custkey, lo_commitdate, lo_extendedprice, ROW_NUMBER() OVER (PARTITION BY lo_orderkey, lo_custkey, lo_commitdate ORDER BY lo_extendedprice) rn from lf where lo_orderkey=20742 and lo_custkey = 27361) x

image

the Plan:
image

the first window required: partition by: 2: lo_orderkey, 4: lo_custkey, 16: lo_commitdate
the second window required: partition by: 2: lo_orderkey, 4: lo_custkey

Although the property of scan output is lo_orderkey, which can meet the requirements of the first and second window, but the first window will insert a local partition, it's will lost lo_orderkey output property, so we can't output child property directly

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.5
    • 3.4
    • 3.3

This is an automatic backport of pull request #60344 done by [Mergify](https://mergify.com).

Signed-off-by: Seaven <seaven_7@qq.com>
(cherry picked from commit 9653e7e)
@wanpengfei-git wanpengfei-git enabled auto-merge (squash) July 3, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant