Skip to content

fix(filters): Remove the ID from the filter names in the dropdown #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Simpler1
Copy link
Contributor

@Simpler1 Simpler1 commented Mar 6, 2025

Simplify the UI slightly by removing the ID from the filter name.

@IgorA100
Copy link
Contributor

IgorA100 commented Mar 6, 2025

Why delete useful information?

@Simpler1
Copy link
Contributor Author

Simpler1 commented Mar 6, 2025

Why would an ID be useful information for a named filter? This is internal data that is not useful to a user. It's just clutter.

@IgorA100
Copy link
Contributor

IgorA100 commented Mar 6, 2025

This is internal data that is not useful to a user

For example, you pressed the "Save as" button, but did not enter a new name. There will be two filters with the same name. How can you tell which was the last one?
Or, for example, to debug filters, it is useful to have a visual comparison of the number and name. Especially when there are many filters.
Surely someone once needed this, since there is code that is not erroneous.

I just expressed my opinion.
In any case, only Isaac makes the decision.

@connortechnology
Copy link
Member

I find the ids to be useful, and indeed I am the one that put the id in the dropdown. When looking at processes and logs, the name is not present and not useful. Hence the id. I agree it isn't great UI for non power users, but for this power user it is very useful. If we had a filter list view then maybe it wouldn't be so important.

@Simpler1
Copy link
Contributor Author

For debugging, it makes sense to show the filter ID. For general usage, it causes confusion. Consider the following two images:
Screenshot from 2025-03-10 09-15-48
Screenshot from 2025-03-10 09-13-24

If you don't want to add this, you can just close this PR.

@IgorA100
Copy link
Contributor

it causes confusion.

  1. You yourself decided to use the ">" sign in the filter name.
  2. Alternatively, the ID can be framed with quotation marks or brackets or something else... If Isaac doesn't mind.

@connortechnology
Copy link
Member

I'm not here to be s tyrant any more than i have to be. We could make it configurable or maybe with further discussion we can come with something better

@connortechnology
Copy link
Member

How about we do either (id) or id: (should make this consistent with monitor ids shown elsewhere). Also can put it in a span or something so that we can hide it with css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants