Fix monthly image data sources in satlas module #137
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were broken because of changes in rslearn where client is no longer created when PlanetaryComputer is initialized, instead it is lazily created.
We should move the monthly functionality to rslearn so this maintenance isn't needed. It is on my TODO list but I haven't gotten around to it yet, so for now still have this PR.
…ces' into favyen/20250515-fix-data-sources
yawenzzzz
approved these changes
Jun 9, 2025
yawenzzzz
pushed a commit
that referenced
this pull request
Jul 3, 2025
Fix monthly image data sources in satlas module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were broken because of changes in rslearn where client is no longer created when PlanetaryComputer is initialized, instead it is lazily created.
We already have a test for this but it wasn't triggered because none of the code in the module changed here. I think we need a recurring weekly test run that runs all of the tests but we can do it in a later PR.