-
-
Notifications
You must be signed in to change notification settings - Fork 9
Revert "Bump @testing-library/user-event from 13.5.0 to 14.6.1" #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Revert "Bump @testing-library/user-event from 13.5.0 to 14.6.1" #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @andeplane, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request reverts a previous change that bumped the version of @testing-library/user-event
from 13.5.0 to 14.6.1. The changes primarily involve modifying the package-lock.json
and package.json
files to restore the older version of the library and its associated dependencies.
Highlights
- Version Reversal: The core change is reverting the version of
@testing-library/user-event
back to 13.5.0 from 14.6.1. - Dependency Updates: The
package-lock.json
file is updated to reflect the dependencies and integrity checksums associated with version 13.5.0 of@testing-library/user-event
.
Changelog
- package-lock.json
- Reverts the version of
@testing-library/user-event
from 14.6.1 to 13.5.0. - Updates the resolved URL and integrity checksum for
@testing-library/user-event
to match version 13.5.0. - Adds
@babel/runtime
as a dependency for@testing-library/user-event
. - Adjusts the engine requirements for
@testing-library/user-event
tonode >=10
.
- Reverts the version of
- package.json
- Reverts the version of
@testing-library/user-event
from 14.6.1 to 13.5.0 in the dependencies section.
- Reverts the version of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Did you know?
The concept of UI testing dates back to the early days of graphical user interfaces, with initial approaches involving manual testing and later evolving into automated testing frameworks.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts a bump in the @testing-library/user-event
dependency. The changes seem straightforward and aim to restore the previous version. I've reviewed the changes and have a few observations.
Merge Readiness
The pull request appears to correctly revert the specified dependency to its previous version. Given the straightforward nature of the change, it seems reasonable to merge after addressing the identified medium severity issue. I am unable to directly approve the pull request, and users should have others review and approve this code before merging.
Qodo Merge was enabled for this repository. To continue using it, please link your Git account with your Qodo account here. PR Code Suggestions ✨No code suggestions found for the PR. |
User description
Reverts #144
PR Type
dependencies
Description
Reverted the version of
@testing-library/user-event
dependency.Updated
package.json
to reflect the reverted dependency version.Changes walkthrough 📝
package.json
Reverted `@testing-library/user-event` dependency version
package.json
@testing-library/user-event
version from 14.6.1 to 13.5.0.package.json
.