Skip to content

[Improvement-17045][UI] copied task joined with underscore #17046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

ChaoquanTao
Copy link
Contributor

Purpose of the pull request

close #17045

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Mar 7, 2025
@SbloodyS SbloodyS added the improvement make more easy to user or prompt friendly label Mar 7, 2025
@SbloodyS SbloodyS added this to the 3.3.0 milestone Mar 7, 2025
Copy link

sonarqubecloud bot commented Mar 7, 2025

@SbloodyS SbloodyS changed the title [Improvement-17045][UI] copied task joined with underscore [Improvement-17045][UI] copied task joined with underscore Mar 11, 2025
@@ -126,7 +126,7 @@ export default defineComponent({
const handleCopy = () => {
const genNums = 1
const type = props.cell?.data.taskType
const taskName = uuid(props.cell?.data.taskName + '_')
const taskName = uuid(props.cell?.data.taskName + '-')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifying the global rule directly will cause other task types to be abnormal, so I think we should create a new rule for the k8s task type.

@SbloodyS SbloodyS modified the milestones: 3.3.0-alpha, 3.3.1 Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][UI] Task name of copied task should be joined with '-' rather than '_'
3 participants