Skip to content

[Improvement-16679][datasource-plugin] Add MariaDB datasource #17205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: dev
Choose a base branch
from
Open

[Improvement-16679][datasource-plugin] Add MariaDB datasource #17205

wants to merge 6 commits into from

Conversation

afriday1015
Copy link

Purpose of the pull request

  • This pull request adds MariaDB datasource.

close #16679

Brief change log

  • Add MariaDB datasource module.
  • Add MariaDB constant definitions, connection parameters, data source processors and other components.
  • Add MariaDB JDBC driver dependency.

Verify this pull request

This change added tests and can be verified as follows:

  • Add DataSourceUtilsTest class to test the datasource utility methods.
  • Add MariaDBDataSourceChannelFactoryTest class to verify the creation methods of the datasource channel factory.
  • Add MariaDBDataSourceChannelTest class to validate the creation of the datasource client through the channel.
  • Add MariaDBDataSourceProcessorTest class to test various functionalities of the datasource processor.

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 23, 2025

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

@github-actions github-actions bot added UI ui and front end related backend test document labels May 23, 2025
SbloodyS
SbloodyS reviewed May 23, 2025
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add api-test or e2e-test @afriday1015

github-advanced-security[bot]
github-advanced-security bot found potential problems May 23, 2025
View reviewed changes
.../org/apache/dolphinscheduler/plugin/datasource/mariadb/param/MariaDBDataSourceProcessor.java
String address = connectionParams.getAddress();
String[] hostSeperator = address.split(Constants.DOUBLE_SLASH);
String[] hostPortArray = hostSeperator[hostSeperator.length - 1].split(Constants.COMMA);
mariadbDatasourceParamDTO.setPort(Integer.parseInt(hostPortArray[0].split(Constants.COLON)[1]));

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.
@afriday1015
Copy link
Author

Please add api-test or e2e-test @afriday1015

Thank you for reviewing the code.
Since this is my first time working on this part, I may have missed some things.
I'll make the necessary changes and update the code. Thanks again!

@github-actions github-actions bot added the e2e e2e test label May 27, 2025
@davidzollo davidzollo added the first time contributor First-time contributor label Jun 7, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
39.1% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SbloodyS SbloodyS SbloodyS left review comments

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@afriday1015 afriday1015

Labels
backend document e2e e2e test first time contributor First-time contributor test UI ui and front end related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement][README] Add MariaDB
3 participants
@afriday1015 @SbloodyS @davidzollo