Skip to content

[Improvement-17267] Throw exception if deserialize json failed in JSONUtils #17243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 5, 2025

Purpose of the pull request

close #17267

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contains incompatible change, you should also add it to docs/docs/en/guide/upgrade/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Jun 5, 2025
@ruanwenjun ruanwenjun marked this pull request as draft June 5, 2025 15:40
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 4 times, most recently from 520eda6 to e2445ca Compare June 9, 2025 14:38
@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Jun 9, 2025
@ruanwenjun ruanwenjun added this to the 3.3.1 milestone Jun 9, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch 7 times, most recently from e0c7b12 to 4c5bfac Compare June 20, 2025 10:28
@ruanwenjun ruanwenjun changed the title Throw exception if deserialize json failed [Improvement-17267] Throw exception if deserialize json failed Jun 20, 2025
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from 4c5bfac to 32f7aa1 Compare June 20, 2025 10:47
@github-actions github-actions bot added the e2e e2e test label Jun 20, 2025
@ruanwenjun ruanwenjun changed the title [Improvement-17267] Throw exception if deserialize json failed [Improvement-17267] Throw exception if deserialize json failed in JSONUtils Jun 20, 2025
@ruanwenjun ruanwenjun marked this pull request as ready for review June 20, 2025 10:50
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_throwExceptionIfParseJsonFailed branch from 32f7aa1 to eeda767 Compare June 21, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend e2e e2e test improvement make more easy to user or prompt friendly test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Throw exception if JSONUtils deserialize json failed
1 participant