Skip to content

[Enhancement] Ignore extra put when checkImmunityTime exceeds the maximum check time range #9320

@WJ66880

Description

@WJ66880
Contributor

Before Creating the Enhancement Request

  • I have confirmed that this should be classified as an enhancement rather than a bug/feature.

Summary

For a half message, if its CHECK_IMMUNITY_TIME_IN_SECONDS property is lager than checkMax * checkInterval, then it will never be checked, but still has been put for checkMax times. It's a waste of put.
If we have a lot of trans messages, the put metrics will by nearly 15 times high.

Motivation

Transactional message's property checkImmunityTime has no upper limit, everyone can set a large value, for example 1800 seconds.

Describe the Solution You'd Like

Continue loop and log warn when CHECK_IMMUNITY_TIME_IN_SECONDS property is lager than checkMax * checkInterval.

Describe Alternatives You've Considered

Do not use checkImmunityTime property, but that's not why it is built for.

Additional Context

No response

Activity

changed the title [-][Enhancement] ignore extra put when checkImmunityTime exceeds the maximum check time range[/-] [+][Enhancement] Ignore extra put when checkImmunityTime exceeds the maximum check time range[/+] on Jun 13, 2025
added a commit that references this issue on Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Participants

      @WJ66880

      Issue actions

        [Enhancement] Ignore extra put when checkImmunityTime exceeds the maximum check time range · Issue #9320 · apache/rocketmq