Adjust buffer sizes.

Author: gbrail

src/apib_io_basic.cc

@@ -256,7 +256,7 @@ void ConnectionState::SendWrite() {
 
 int ConnectionState::singleRead(struct ev_loop* loop, ev_io* w, int revents) {
   io_Verbose(this, "I/O ready on read path: %i\n", revents);
-  const size_t len = readBufSize - readBufPos_;
+  const size_t len = kReadBufSize - readBufPos_;
   assert(len > 0);
 
   size_t readCount;

src/apib_iothread.cc

@@ -34,16 +34,15 @@ namespace apib {
 http_parser_settings IOThread::parserSettings_;
 static std::once_flag parserInitalized;
 
-ConnectionState::ConnectionState(int index, IOThread* t) {
-  index_ = index;
+ConnectionState::ConnectionState(int index, IOThread* t) : index_(index) {
   keepRunning_ = 1;
   t_ = t;
-  readBuf_ = (char*)malloc(readBufSize);
+  readBuf_ = new char[kReadBufSize];
 }
 
 // TODO memory leak -- COnnectionStates are freed when threads exit but not
 // when they just close. Think of a way to handle this...
-ConnectionState::~ConnectionState() { free(readBuf_); }
+ConnectionState::~ConnectionState() { delete[] readBuf_; }
 
 int ConnectionState::httpComplete(http_parser* p) {
   ConnectionState* c = (ConnectionState*)p->data;

src/apib_iothread.h

@@ -173,8 +173,13 @@ class ConnectionState {
   static int httpComplete(http_parser* p);
 
  private:
-  static constexpr int readBufSize = 512;
-  static constexpr int writeBufSize = 1024;
+  // The size of the buffer to read from when calling read()
+  // or SSL_read()
+  static constexpr int kReadBufSize = 8192;
+  // In the event that connecting a socket fails, we will wait
+  // for this time, in seconds, before trying again.
+  // Nevertheless, if this ever gets used then the benchmark
+  // is pretty much ruined anyway...
   static constexpr double kConnectFailureDelay = 0.25;
 
   void addThinkTime();
@@ -195,7 +200,7 @@ class ConnectionState {
   static void writeReady(struct ev_loop* loop, ev_io* w, int revents);
   static void thinkingDone(struct ev_loop* loop, ev_timer* t, int revents);
 
-  int index_ = 0;
+  const int index_ = 0;
   bool keepRunning_ = 0;
   IOThread* t_ = nullptr;
   int fd_ = 0;