Skip to content

Tighten up security on docker compose files (backport #7681) #7686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 1.x
Choose a base branch
from

Conversation

garypen
Copy link
Contributor

@garypen garypen commented Jun 13, 2025

In our docker compose files (used for integration testing):

- Enable no-new-privileges to prevent privilege escalation attacks.
- Make root file systems read-only where possible

[OE-827]: https://apollographql.atlassian.net/browse/OE-827?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ


This is an automatic backport of pull request #7681 done by Mergify.

(cherry picked from commit 68423d9)

# Conflicts:
#	dockerfiles/docker-compose-redis.yml
@mergify mergify bot added the conflicts label Jun 13, 2025
Copy link
Contributor

mergify bot commented Jun 13, 2025

Cherry-pick of 68423d9 has failed:

On branch mergify/bp/1.x/pr-7681
Your branch is up to date with 'origin/1.x'.

You are currently cherry-picking commit 68423d91.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docker-compose.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   dockerfiles/docker-compose-redis.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant