Use new subgraph mocking functionality for canned test supergraph #7711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These used to have errors because the subgraph mocks did not support the
test query:
```
couldn't find mock for query {"query":"{ topProducts { name } }"}
```
Now the mocks use an execution engine so it returns a valid response.
|
@goto-bus-stop, please consider creating a changeset entry in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of our tests use a simple "canned" default schema. This PR replaces the hardcoded query/response mocks with the new subgraph mocking functionality that uses a GraphQL execution engine for that schema.
This is more future-proof in case query plans change in benign ways.
Additionally:
axum_factory::tests::defer_is_not_bufferedwas using a query that didn't have existing mocks, but now it workshas_errors: true, now it works