Skip to content

Commit b612d9a

Browse files
authored
Add a comment for MUSUnsafe results to README (alecthomas#127)
1 parent e716561 commit b612d9a

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

README.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,11 +239,16 @@ Unfortunately, several of the serializers exhibit issues:
239239

240240
All other fields are correct however.
241241

242-
Additionally, while not a correctness issue, FlatBuffers, ProtoBuffers, Cap'N'Proto and ikeapack do not
243-
support time types directly. In the benchmarks an int64 value is used to hold a UnixNano timestamp.
242+
Additionally, while not a correctness issue, FlatBuffers, ProtoBuffers, Cap'N'Proto, ikeapack and MUS
243+
do not support time types directly. In the benchmarks an int64 value is used to hold a UnixNano timestamp.
244244

245245
Bebop (both libraries, by nature of the format) natively supports times rounded to 100ns ticks, and this is what is currently benchmarked (a unix nano timestamp is another valid approach).
246246

247+
MUSUnsafe results were obtained using the mus-go unsafe package. With this
248+
package, after decoding a byte slice into a string, any change to this slice
249+
will change the contents of the string. In such cases, the slice can be reused
250+
only after processing the received result.
251+
247252
3. **(major)** Goprotobuf has been disabled in the above, as it is no longer maintained and is incompatible with the latest changes to Google's Protobuf package. See discussions: [1](https://github.com/containerd/ttrpc/issues/62), [2](https://github.com/containerd/ttrpc/pull/99).
248253

249254
```

0 commit comments

Comments
 (0)