-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Open
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Rules-CPPIssues for C++ rulesIssues for C++ rulestype: bug
Description
Description of the problem / feature request:
strip_include_prefix
in cc_*
rules is super useful, but it needs to apply to textual_hdrs
as well as hdrs
. The inconsistency is extremely problematic for rules successfully using either textual_hdrs
or strip_include_prefix
.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Given this rule:
cc_library(
name = "test",
hdrs = ["some/path/prefix/normal_header.h"
textual_hdrs = ["some/path/prefix/textual_header.h"],
strip_include_prefix = "some/path/prefix",
)
Rules depending on :test
can #include "normal_header.h"
as expected, but cannot #include "textual_header.h"
.
What operating system are you running Bazel on?
Impacts all OSes AFAICT, tested on Linux.
What's the output of bazel info release
?
release 3.3.1
hawkinsp, GMNGeoffrey, russellsch, matthew-reynolds, cramertj and 1 more
Metadata
Metadata
Assignees
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Rules-CPPIssues for C++ rulesIssues for C++ rulestype: bug
Activity
includes
directive fromtblgen
libraries. google/llvm-bazel#82Remove the `includes` directive from `tblgen` libraries. (#82)
github-actions commentedon Apr 13, 2023
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 2+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (
@bazelbuild/triage
) if you think this issue is still relevant or you are interested in getting the issue resolved.chandlerc commentedon Apr 13, 2023
@bazelbuild/triage - This is definitely still relevant and I'd like to see it resolved.
Pretty sure it was triaged and a team added back in 2020, but then marked as untriaged... 🤷
github-actions commentedon Jun 17, 2024
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.
28 remaining items