Skip to content

Revert "Propagate linkopts of header-only libraries to cc_shared_library #26313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 16, 2025

This reverts commit 0fdb36f.

@fmeum fmeum requested a review from meteorcloudy June 16, 2025 12:27
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 16, 2025
@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label Jun 16, 2025
@meteorcloudy
Copy link
Member

Looks like some test needs a bit of tweak

@fmeum fmeum force-pushed the revert-linkopts branch from c363442 to 9ecf52b Compare June 17, 2025 10:14
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 17, 2025

@meteorcloudy Fixed!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 17, 2025
copybara-service bot pushed a commit that referenced this pull request Jun 24, 2025
…ary" #26313

PiperOrigin-RevId: 775187961
Change-Id: Id3f7533b9fe7f7955b2f40bfa9fe86951dfd3c56
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 15, 2025

Merged in 7c5b158

@fmeum fmeum closed this Jul 15, 2025
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants