-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Overlay the registry MODULE.bazel
file on the module repo
#26332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
82b693d
to
66d4bf1
Compare
So even if the source archive already contains a MODULE.bazel, it'll still be overridden by the one from the registry, right? If we do this, we probably have to also backport to both bazel 7 and 8. Even with that, I'm just a bit concerned if we loose up the restriction on BCR side, there might be unexpected problems for users not using latest minor versions of Bazel 7 & 8? @Wyverald WDYT? |
Yes, but for existing registry versions we've verified that both agree. That won't necessarily be true for custom registries though. We could decide to loosen restrictions later, say when Bazel 9 is out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
src/main/java/com/google/devtools/build/lib/bazel/bzlmod/Registry.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/devtools/build/lib/bazel/bzlmod/IndexRegistryTest.java
Outdated
Show resolved
Hide resolved
@bazel-io fork 8.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, if we delay the loosing of BCR restriction to Bazel 9, then I have no concern!
RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes bazelbuild#26217 Closes bazelbuild#26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9
…26462) RELNOTES: Modules backed by `http_archive` or `git_repository` no longer require a MODULE.bazel file to be contained in the source archive. Fixes #26217 Closes #26332. PiperOrigin-RevId: 778139801 Change-Id: Ie1d219ce1c219c8bae7657be929e54b9b467abf9 Commit c5a562b --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
RELNOTES: Modules backed by
http_archive
orgit_repository
no longer require a MODULE.bazel file to be contained in the source archive.Fixes #26217