Skip to content

Add baseline coverage support to Java compilation action #26341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 19, 2025

  • JacocoInstrumentationProcessor optionally analyzes all instrumented classes with null probes and generates an LCOV baseline report.
  • create_compilation_action gains a baseline_coverage_file parameter that rules_java can use to supply the desired output file for the baseline report.

Work towards #5716

@fmeum fmeum force-pushed the 5716-java-baseline-coverage branch 3 times, most recently from 5a544a7 to dc0b753 Compare June 19, 2025 11:28
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 19, 2025

Stacked on #26340, please ignore the first commit.
Enabling the test requires a small change to rules_java that I will send out for review after this PR has been merged: bazelbuild/rules_java#304

@fmeum fmeum marked this pull request as ready for review June 19, 2025 12:54
@fmeum fmeum requested review from a team and lberki as code owners June 19, 2025 12:54
@fmeum fmeum requested review from mai93 and cushon and removed request for a team, lberki and mai93 June 19, 2025 12:54
@github-actions github-actions bot added team-Configurability platforms, toolchains, cquery, select(), config transitions team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Jun 19, 2025
@fmeum fmeum requested a review from c-mita June 19, 2025 12:54
fmeum added 2 commits June 27, 2025 12:59
# Conflicts:
#	src/java_tools/buildjar/java/com/google/devtools/build/buildjar/instrumentation/JacocoInstrumentationProcessor.java
@fmeum fmeum force-pushed the 5716-java-baseline-coverage branch from e361e1d to b6b39df Compare June 27, 2025 11:01
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 27, 2025

@c-mita @cushon No longer stacked and ready for review.

@c-mita c-mita requested a review from hvadehra June 27, 2025 12:44
@hvadehra hvadehra added coverage and removed team-Configurability platforms, toolchains, cquery, select(), config transitions labels Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-review PR is awaiting review from an assigned reviewer coverage team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants