Add support for directories in baseline_coverage_files
#26349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
5716-refactor-coverage-generator
branch
3 times, most recently
from
ec28a95 to
20a7862
Compare
|
Any chance you might do something about this? The warning would be a meaningful addition to a cleanup. |
fmeum
force-pushed
the
5716-refactor-coverage-generator
branch
4 times, most recently
from
226b012 to
11a857c
Compare
fmeum
changed the title
baseline_coverage_files
* Don't reparse regexes for each source file. * Fail on "SEVERE" errors rather than continuing with arbitarily truncated data. * Consistently use `Path` throughout.
fmeum
force-pushed
the
5716-refactor-coverage-generator
branch
3 times, most recently
from
0f9928d to
7b89648
Compare
fmeum
force-pushed
the
5716-refactor-coverage-generator
branch
from
7b89648 to
9a2b790
Compare
We would want to add this carefully as it risk being very noisy (but also useful). It's probably be better to do this in a separate PR so that it can also be rolled back independently if needed. |
github-actions
bot
added
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files in
baseline_coverage_filescan now be tree artifacts that themselves contain coverage files. In addition,.gcovand.gcov.json.gzfiles can now also be provided for baseline coverage. Both is needed for support of GCC-style baseline coverage, which will be added in a follow-up PR.Along the way, clean up CoverageOutputGenerator:
Path.Work towards #5716