Skip to content

Commit 42b7487

Browse files
enable std when building bevy_dylib (#18405)
- bevy_dylib fails to build: ``` Compiling bevy_dylib v0.16.0-rc.1 (/bevy/crates/bevy_dylib) error: linking with `cc` failed: exit status: 1 | = note: some arguments are omitted. use `--verbose` to show all linker arguments = note: Undefined symbols for architecture arm64: "__critical_section_1_0_acquire", referenced from: critical_section::with::h00cfbe529dea9dc9 in libbevy_tasks-53c9db6a3865f250.rlib[58](bevy_tasks-53c9db6a3865f250.evom2xwveqp508omiiqb25xig.rcgu.o) "__critical_section_1_0_release", referenced from: core::ptr::drop_in_place$LT$critical_section..with..Guard$GT$::hfa034e0208e1a49d in libbevy_tasks-53c9db6a3865f250.rlib[48](bevy_tasks-53c9db6a3865f250.d9dwgpd0156zfn2h5z5ff94zn.rcgu.o) ld: symbol(s) not found for architecture arm64 clang: error: linker command failed with exit code 1 (use -v to see invocation) ``` - enable `std` when building bevy_dylib --------- Co-authored-by: Zachary Harrold <zac@harrold.com.au>
1 parent f3cbe42 commit 42b7487

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

crates/bevy_dylib/Cargo.toml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ keywords = ["bevy"]
1212
crate-type = ["dylib"]
1313

1414
[dependencies]
15-
bevy_internal = { path = "../bevy_internal", version = "0.16.0-rc.1", default-features = false }
15+
# feature std is needed to avoid an issue when linking critical_section
16+
# bevy_dylib is not expected to work in no_std
17+
bevy_internal = { path = "../bevy_internal", version = "0.16.0-rc.1", default-features = false, features = [
18+
"std",
19+
] }
1620

1721
[lints]
1822
workspace = true

0 commit comments

Comments
 (0)