Skip to content

Allow passing number of thread for building and testing to CI #19359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
Jun 16, 2025
Merged

Allow passing number of thread for building and testing to CI #19359

merged 35 commits into from
Jun 16, 2025

Conversation

hukasu
Copy link
Contributor

@hukasu hukasu commented May 24, 2025 •
edited
Loading

Objective

Fixes #16051
Closes #16145

Solution

Allow passing --build-jobs and --test-threads to ci
i.e.

cargo run -p ci -- --build-jobs 4 --test-threads 4

Testing

running ci locally

BenjaminBrienen and others added 30 commits October 29, 2024 00:16
@BenjaminBrienen
add argument to ci for test threads
2cf22b5
@BenjaminBrienen
build jobs
e2c30c3
@BenjaminBrienen
Merge branch 'main' into test-threads-in-ci-doc-test
07ad724
@BenjaminBrienen
use --jobs
3a06f8e
@BenjaminBrienen
Merge branch 'test-threads-in-ci-doc-test' of github.com:BenjaminBrie…
8aaf9ae 
…nen/bevy into test-threads-in-ci-doc-test
@BenjaminBrienen
Merge branch 'main' into test-threads-in-ci-doc-test
bad41ef
@BenjaminBrienen
spacing
69716d6
@BenjaminBrienen
test threads spacing
76bbf8e
@BenjaminBrienen
Merge branch 'main' into test-threads-in-ci-doc-test
57e29f0
@BenjaminBrienen
Merge branch 'main' into test-threads-in-ci-doc-test
fe4e0de
@BenjaminBrienen
Merge branch 'main' into test-threads-in-ci-doc-test
6f2f6d5
@BenjaminBrienen
Update test.rs
3b76bef
@BenjaminBrienen
Update bench_check.rs
459146d
@BenjaminBrienen
Update clippy.rs
0a243bc
@BenjaminBrienen
Update compile_check.rs
7c2fb9d
@BenjaminBrienen
Update compile_check_no_std.rs
2be4e6a
@BenjaminBrienen
Update doc_check.rs
73aaf78
@BenjaminBrienen
Update doc_test.rs
74f72e9
@BenjaminBrienen
Update example_check.rs
59c9127
@BenjaminBrienen
Update format.rs
9c795ea
@BenjaminBrienen
Update test.rs
1709ea0
@BenjaminBrienen
Update test_check.rs
d7d808d
@BenjaminBrienen
Update format.rs
8600341
@BenjaminBrienen
Update doc_check.rs
9bd9930
@hukasu
Rename jobs to build_jobs
5473ebc
@hukasu
Merge branch 'main' into test-threads-in-ci-doc-test
de58390
@hukasu
Fix bench_check
3d69b4f
@hukasu
Fix clippy
69f0885
@hukasu
Fix compile_check
f49a8bb
@hukasu
Fix compile_fail
d79738f
@BD103 BD103 added C-Feature A new feature, making something new possible A-Build-System Related to build systems or continuous integration D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 25, 2025
@BD103 BD103 mentioned this pull request May 25, 2025
Closed
janhohenheim
janhohenheim approved these changes Jun 15, 2025
View reviewed changes
Copy link
Member

@janhohenheim janhohenheim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible to me

@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 15, 2025
@hukasu hukasu changed the title Test threads in ci doc test Allow passing number of thread for building and testing to CI Jun 15, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 16, 2025
Merged via the queue into bevyengine:main with commit c8cb7bd Jun 16, 2025
47 checks passed
@hukasu hukasu deleted the test-threads-in-ci-doc-test branch June 19, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhohenheim janhohenheim janhohenheim approved these changes

@BenjaminBrienen BenjaminBrienen BenjaminBrienen approved these changes

Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing --jobs to ci to prevent OOM on home machines
5 participants
@hukasu @janhohenheim @BenjaminBrienen @alice-i-cecile @BD103