Fix Keyboard observer not updating SliderValue #19661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case that the slider has no on_change system set, it will now update SliderValue correctly.
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
added
C-Bug
viridia
approved these changes
Jun 15, 2025
alice-i-cecile
approved these changes
Jun 16, 2025
…r-without-systemid
alice-i-cecile
added
S-Ready-For-Final-Review
|
Okay, that should have fixed CI for you :) I'll grab this in my merge train tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
When the
CoreSliderson_changeis set to None, Keyboard input, like ArrowKeys, does not update theSliderValue.Solution
Handle the missing case, like it is done for Pointer.
Testing
Did you test these changes?
Yes: core_widgets & core_widgets_observers
in both examples one has to remove / comment out the setting of
CoreSlider::on_changeto test the case ofon_changebeing none.Are there any parts that need more testing?
No not that I am aware of.
How can other people (reviewers) test your changes? Is there anything specific they need to know?
Yes: core_widgets & core_widgets_observers
in both examples one has to remove / comment out the setting of
CoreSlider::on_changeto test the case ofon_changebeing none.If relevant, what platforms did you test these changes on, and are there any important ones you can't test?
I tested on linux + wayland. But it is unlikely that it would effect outcomes.