-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Allow setting correct glTF coordinate conversions globally #19685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 17 commits into
bevyengine:main
from
janhohenheim:global-gltf-loader-settings
Jun 24, 2025
Merged
Allow setting correct glTF coordinate conversions globally #19685
alice-i-cecile
merged 17 commits into
bevyengine:main
from
janhohenheim:global-gltf-loader-settings
Jun 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
approved these changes
Jun 17, 2025
greeble-dev
reviewed
Jun 17, 2025
greeble-dev
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Although the Arc<AtomicBool>
can be changed to a plain bool now that it's no longer shared with the resource?
Trashtalk217
pushed a commit
to Trashtalk217/bevy
that referenced
this pull request
Jul 10, 2025
…e#19685) # Objective - Followup to bevyengine#19633 - As discussed, it's a bit cumbersome to specify that you want the correct orientation every single time - Also, glTFs loaded from third parties will still be loaded incorrectly ## Solution - Allow opting into the new behavior globally or per-asset - Also improved some docs while on it :) ## Testing - Ran the animation examples - Ran the test scene from the last PR with all configuration combinations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-glTF
Related to the glTF 3D scene/model format
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing