Skip to content

Allow setting correct glTF coordinate conversions globally #19685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

janhohenheim
Copy link
Member

@janhohenheim janhohenheim commented Jun 16, 2025

Objective

Solution

  • Allow opting into the new behavior globally or per-asset
  • Also improved some docs while on it :)

Testing

  • Ran the animation examples
  • Ran the test scene from the last PR with all configuration combinations

@janhohenheim janhohenheim added C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-glTF Related to the glTF 3D scene/model format labels Jun 16, 2025
@janhohenheim janhohenheim added this to the 0.17 milestone Jun 16, 2025
@janhohenheim janhohenheim changed the title Global gltf loader settings Allow setting correct glTF coordinate conversions globally Jun 16, 2025
@janhohenheim janhohenheim requested a review from greeble-dev June 17, 2025 14:28
Copy link
Contributor

@greeble-dev greeble-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although the Arc<AtomicBool> can be changed to a plain bool now that it's no longer shared with the resource?

@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 17, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 24, 2025
Merged via the queue into bevyengine:main with commit f3d94f3 Jun 24, 2025
32 checks passed
Trashtalk217 pushed a commit to Trashtalk217/bevy that referenced this pull request Jul 10, 2025
…e#19685)

# Objective

- Followup to bevyengine#19633
- As discussed, it's a bit cumbersome to specify that you want the
correct orientation every single time
- Also, glTFs loaded from third parties will still be loaded incorrectly

## Solution

- Allow opting into the new behavior globally or per-asset
- Also improved some docs while on it :)

## Testing

- Ran the animation examples
- Ran the test scene from the last PR with all configuration
combinations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-glTF Related to the glTF 3D scene/model format C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants