Skip to content

Don't break use-context shared-gdrive if a file is renamed #517

Open
@asolove

Description

@asolove

@schanzer reports:

When loading a context via shared-gdrive, for some reason the fileID and fileName are required. If the filename of the file being loaded changes, it breaks every program that loads it! This is a maintenance nightmare. Would it be possible to just check the name of the file when it loads, and update the string accordingly?

AFAICT from debugging this, we only need the id to fetch the contents of the file from a security/permissions standpoint. Even if I change the file name to be wrong, the contents of the file are fetched by id and make it all the way to the browser. We're just choosing to throw an error after that if the name doesn't match.

From a cursory look, this seems not hard to fix. But before I attempt a fix, I am filing this issue so someone has a chance to tell me this is a load-bearing error or if there is some history as to why the name match is enforced.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions