Generate a warning (or two?) for stencil-distributed arrays of owned classes #27454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes This follows up on a suggestion [made by Lydia](https://chapel.discourse.group/t/unable-to-compile-pure-virtual-method-called/43307/15?u=bradcray) to generate a warning when creating a Stencil-distributed array, because calling the updateFluff() method on such an array has the effect of turning array elements into 'nil' values when they are copied into their neighbor's caches (fluff) since the ownership will be transferred. For some reason that I didn't have time to investigate, this generates two warnings rather than one for a simple program. At present, my thought is that two is better than zero. :) --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
bradcray
changed the title
|
@lydia-duncan : Would you be up for reviewing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up on a suggestion made by Lydia to generate a warning when creating a Stencil-distributed array, because calling the updateFluff() method on such an array has the effect of turning array elements into 'nil' values when they are copied into their neighbor's caches (fluff) since the ownership will be transferred.
For some reason that I didn't have time to investigate, this generates two warnings rather than one for a simple program. At present, my thought is that two is better than zero. :)