-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Force Id
spelling in cypress tests
#9491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Id
spelling in cypress testsId
spelling in cypress tests
/check |
❌ Some checks failed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9491 +/- ##
========================================
Coverage 73.73% 73.74%
========================================
Files 448 448
Lines 46638 46638
Branches 3936 3936
========================================
+ Hits 34388 34392 +4
+ Misses 12250 12246 -4
🚀 New features to boost your workflow:
|
|
@archibald1418, the PR looks good overall, but Also, since you’ve updated the names in the objects returned by the commands, please make sure to check the E2E tests in the private repositories. Create the corresponding branches and verify that CI passes there as well. |
I suppose in the future this can be enforced by a spell-checker |
Motivation and context
Set
Id
spelling in stone to avoid further confusionHow has this been tested?
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.