Skip to content

Force Id spelling in cypress tests #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

archibald1418
Copy link
Contributor

Motivation and context

Set Id spelling in stone to avoid further confusion

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@archibald1418 archibald1418 requested a review from bsekachev as a code owner June 2, 2025 10:01
@archibald1418 archibald1418 removed the request for review from bsekachev June 2, 2025 10:03
@archibald1418 archibald1418 changed the title [WIP] Force Id spelling in cypress tests Force Id spelling in cypress tests Jun 3, 2025
@archibald1418
Copy link
Contributor Author

/check

Copy link
Contributor

github-actions bot commented Jun 3, 2025

❌ Some checks failed
📄 See logs here

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.74%. Comparing base (218f48c) to head (0de5c0a).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9491   +/-   ##
========================================
  Coverage    73.73%   73.74%           
========================================
  Files          448      448           
  Lines        46638    46638           
  Branches      3936     3936           
========================================
+ Hits         34388    34392    +4     
+ Misses       12250    12246    -4     
Components Coverage Δ
cvat-ui 77.75% <ø> (+0.01%) ⬆️
cvat-server 70.62% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@klakhov
Copy link
Contributor

klakhov commented Jun 19, 2025

@archibald1418, the PR looks good overall, but case_search_by_filename needs to be fixed.

Also, since you’ve updated the names in the objects returned by the commands, please make sure to check the E2E tests in the private repositories. Create the corresponding branches and verify that CI passes there as well.

@archibald1418
Copy link
Contributor Author

I suppose in the future this can be enforced by a spell-checker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants