Skip to content

Add page size for different pages #9527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Add page size for different pages #9527

wants to merge 22 commits into from

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Jun 11, 2025

Motivation and context

  • The PR adds page size selector for different pages.
  • Also added optimization logic into preview fetching: request for preview will only be sent when the card is in user view
  • Unified card views page with scrollbars like on task page
  • Changed models card design a bit so 12 of them are fit on the page like projects
  • Added hook for updatedQuery to reduce code duplication

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.78%. Comparing base (d7a9f97) to head (41bd921).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9527      +/-   ##
===========================================
+ Coverage    73.76%   73.78%   +0.01%     
===========================================
  Files          448      448              
  Lines        46695    46697       +2     
  Branches      3942     3945       +3     
===========================================
+ Hits         34446    34456      +10     
+ Misses       12249    12241       -8     
Components Coverage Δ
cvat-ui 77.76% <94.59%> (+0.04%) ⬆️
cvat-server 70.69% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@klakhov
Copy link
Contributor Author

klakhov commented Jun 11, 2025

@bsekachev What do you think, should we add scrollbar into pages with card views?

@bsekachev
Copy link
Member

Layout on jobs page changed if there are less than 10 cards (the same for projects page)
image

Also cannot apply any filter or search on jobs page (need to check other pages)
image

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants