Skip to content

Refactor iam permissions #9557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Refactor iam permissions #9557

wants to merge 8 commits into from

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 20, 2025

Motivation and context

IAM defines quite rigid data structures, which require more changes than necessary, when inherited and overridden. This PR simplifies overriding the IAM functionality in other components.

  • Refactored IAM permissions
    • Updated rego file name pattern to exclude incorrect file skips
    • Sorted scope lists for better readability
    • Fixed payload setup in log viewer
    • Added more detailed methods for payload setup and in PolicyEnforcer for better extensibility
  • Enabled import checks in regal
  • Cleaned code for long removed endpoints in engine permissions

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@zhiltsov-max zhiltsov-max requested a review from SpecLad as a code owner June 20, 2025 15:51
@zhiltsov-max zhiltsov-max marked this pull request as draft June 23, 2025 11:48
@zhiltsov-max zhiltsov-max marked this pull request as ready for review June 23, 2025 14:23
@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2025

Codecov Report

Attention: Patch coverage is 94.31818% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.80%. Comparing base (e939907) to head (db83c91).
Report is 21 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #9557   +/-   ##
========================================
  Coverage    73.79%   73.80%           
========================================
  Files          448      448           
  Lines        46695    46790   +95     
  Branches      3942     3943    +1     
========================================
+ Hits         34460    34533   +73     
- Misses       12235    12257   +22     
Components Coverage Δ
cvat-ui 77.73% <ø> (-0.07%) ⬇️
cvat-server 70.76% <94.31%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@zhiltsov-max zhiltsov-max requested review from Eldies and removed request for SpecLad July 1, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants