Skip to content

Mark videos unavailable in discovery instead of removing + Opencast API connectivity check in cronjobs #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Mark videos unavailable in discovery instead of removing + Opencast API connectivity check in cronjobs #1387

wants to merge 5 commits into from

Conversation

ferishili
Copy link
Contributor

This PR fixes #1374,

Main changes in this PR are:

  • Introducing cronjob utils namespace which has a trait for oc conecttion
  • A new method: OCConfig::checkOpencastAPIConnectivity
  • All cronjobs now have a connection checker before processing.
  • Video is marked unavailable when they are no longer found in OC.

NOTE: It would be very helpful to test all cronjobs and verify that everything works as expected!

@ferishili
changes according to discussion:
bb9a171 
- introducing cronjob utils: oc conecttion trait with OCConfig::checkOpencastAPIConnectivity.
- all cronjobs now have a connection checker before processing.
- video is marked unavailable when they are no longer found in OC.
@ferishili ferishili requested review from tgloeggl and dennis531 June 11, 2025 06:54
@ferishili ferishili self-assigned this Jun 11, 2025
@ferishili ferishili added type:enhancement type:bug v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x labels Jun 11, 2025
ferishili added 2 commits June 11, 2025 12:21
@ferishili
Merge branch 'main' into issue-1374
8794a67
@ferishili
changes according to request:
49b4d95 
- add a global functional config to toggle the listing of unavailable videos
@ferishili
Copy link
Contributor Author

@tgloeggl
the config is there now, please proceed!

This was referenced Jun 11, 2025
Open
Open
@dennis531
Copy link
Collaborator

I wonder if it is intended that the cronjob "Opencast - Aufzeichnungsplanung aktualisieren" continues to be executed when my OC is offline:

image

@ferishili
Copy link
Contributor Author

Of course not! It has to terminate the process!

dennis531
dennis531 reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@dennis531 dennis531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix!

The new configuration for hiding unavailable videos is working great!

Regarding the server availability check, I am wondering whether this check is sufficient for an OC cluster. For example, the admin node could be available, but not the worker nodes or the presentation node. I am assuming that your implementiation is only checking the admin node.

@ferishili
Copy link
Contributor Author

True, multi-node opencast was not covered, and should be considered of course!

@ferishili
Copy link
Contributor Author

Thanks @dennis531,
I've added support to check the Engage node connectivity.
However, after reviewing all current cronjobs, it appears that they all operate with the Admin node, so no immediate changes are required for them.

@ferishili ferishili requested a review from dennis531 June 17, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennis531 dennis531 dennis531 approved these changes

@tgloeggl tgloeggl Awaiting requested review from tgloeggl

Assignees

@ferishili ferishili

Labels
type:bug type:enhancement v:3 Everything related to the Stud.IP Opencast Plugin Version 3.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zuordnung der Videos zu Wiedergabelisten nach Störung im Opencasthosting verschwunden
2 participants
@ferishili @dennis531