-
Notifications
You must be signed in to change notification settings - Fork 176
Add filebeat_input to beat receiver agent monitoring integration test #8338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filebeat_input to beat receiver agent monitoring integration test #8338
Conversation
This pull request does not have a backport label. Could you fix it @leehinman? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why changes to the existing test cases are necessary in this PR. Why does uncommenting the filebeat input test case not suffice?
2 things.
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request is now in conflicts. Could you fix it? 🙏
|
f6d024a
to
c786566
Compare
@mauri870 @swiatekm @khushijain21 please take another look, should be clearer now. |
@leehinman you need to update the monitoring config generation unit tests. |
c786566
to
d38eed5
Compare
🤦 done. |
FYI, the serverless tests are failing due to an unrelated infrastructure problem right now. |
d38eed5
to
b16e612
Compare
Looks like the modified test fails right now. |
0e2024f
to
d403bf9
Compare
|
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @leehinman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
…itoring integration test (#8473) * Add filebeat_input to beat receiver agent monitoring integration test (#8338) (cherry picked from commit b8882aa) # Conflicts: # testing/integration/beat_receivers_test.go * Fix conflicts --------- Co-authored-by: Lee E Hinman <57081003+leehinman@users.noreply.github.com> Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
What does this PR do?
Adds last part of comparing process based monitoring vs beat receiver based monitoring
Why is it important?
We need to make sure that both implementations produce the same documents.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
None. Unit test and changes to producing configuration when experimental runtime is used.
How to test this PR locally
Related issues
Questions to ask yourself