Skip to content

[8.19] (backport #8326) fix(ci): restore go mod tidy in otel-update.sh script #8350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 5, 2025

Without it, mage notice fails, because mage tidy fails, because magefile cannot be compiled, because the root go.mod file that Mage depends on is out of date.

Related to #8279, discussed with @pkoutsovasilis.

Steps to reproduce the issue

  1. Pull latest main
  2. Run .ci/scripts/otel-update.sh v0.127.0 v1.33.0, or make some other change in the root go.mod that invalidates go.sum.

Expected result:

  • The otel-update.sh scripts / mage tidy succeeds

Actual result:

  • The otel-update.sh script fails with error compiling magefiles
$ .ci/scripts/otel-update.sh v0.127.0 v1.33.0
=> Updating core from v0.123.0/v1.29.0 to v0.127.0/v1.33.0
=> Updating contrib from v0.123.0 to v0.127.0
=> Running mage notice
internal/pkg/config/config.go:13:2: missing go.sum entry for module providing package go.opentelemetry.io/collector/confmap (imported by github.com/elastic/elastic-agent/internal/pkg/config); to add:
        go get github.com/elastic/elastic-agent/internal/pkg/config
Error: error compiling magefiles
$
<hr>This is an automatic backport of pull request #8326 done by [Mergify](https://mergify.com).

Without it, `mage notice` fails, because `mage tidy` fails, because magefile cannot be compiled, because the root `go.mod` file that Mage depends on is out of date.

(cherry picked from commit bb6eff4)
@mergify mergify bot added the backport label Jun 5, 2025
@mergify mergify bot requested a review from a team as a code owner June 5, 2025 11:21
@mergify mergify bot added the backport label Jun 5, 2025
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Jun 5, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor Author

mergify bot commented Jun 9, 2025

This pull request has not been merged yet. Could you please review and merge it @andrzej-stencel? 🙏

@andrzej-stencel andrzej-stencel merged commit 404ef8e into 8.19 Jun 9, 2025
11 checks passed
@andrzej-stencel andrzej-stencel deleted the mergify/bp/8.19/pr-8326 branch June 9, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants