-
Notifications
You must be signed in to change notification settings - Fork 176
buildkite(scripts): refactor common scripts #8365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
💚 Build Succeeded
cc @v1v |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM it's so great to see unnecessary scripts/files getting removed!
I also couldn't find any uses of google_cloud_auth()
so it's great that it gets removed from both.
@Mergifyio backport 8.17 8.18 8.19 9.0 |
✅ Backports have been created
|
(cherry picked from commit c01278b)
(cherry picked from commit c01278b)
(cherry picked from commit c01278b)
@Mergifyio backport 9.0 |
✅ Backports have been created
|
(cherry picked from commit c01278b)
…ts-oblt-cli * feature/serverless-its-oblt-cli: (51 commits) as agreed let's move the group to the kb.integration pipeline Update .github/workflows/serverless-project.yml ci: invoke serverless integration tests package from BK github-actions: create a serverless project daily [tests] split up serverless and resource leaks integration tests (#8396) chore: Update to elastic/beats@dfdc12e33de0 (#8446) Lock upgrade marker (#8254) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420) Add docker image name template and renamed fips cloud specs (#8429) buildkite(scripts): refactor common scripts (#8365) Use require.Eventually to try and address flakiness (#8421) Fix pre-command to support extended testing (#8418) [Automation] Bump Golang version to 1.24.4 (#8384) chore: Update to elastic/beats@aed2a8b768bd (#8423) [main][Automation] Update versions (#8425) Add Pipeline to deploy custom agent image for FIPS testing (#8035) ci: automatically update OTel components (#8288) [Automation] Bump VM Image version to 1749258065 (#8390) fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374) otel: add cumulativetodeltaprocessor to EDOT collector (#8372) ...
What does this PR do?
common2.sh
Why is it important?
Tidy up the code and the usage:
common2.sh
does not contain much logic, and some env variables are already created in thepre-command
hook when it runs thecommon.sh
script.common2.sh
name is not clear enough.google_cloud_auth
function is not actually called anywhere as far I can see at the GitHub search.Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself