Skip to content

buildkite(scripts): refactor common scripts #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jun 5, 2025

What does this PR do?

  • Remove common2.sh
  • Remove unused function

Why is it important?

Tidy up the code and the usage:

  • common2.sh does not contain much logic, and some env variables are already created in the pre-command hook when it runs the common.sh script.
  • common2.sh name is not clear enough.
  • google_cloud_auth function is not actually called anywhere as far I can see at the GitHub search.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v self-assigned this Jun 5, 2025
@v1v v1v added skip-changelog backport-active-all Automated backport with mergify to all the active branches labels Jun 5, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @v1v

@v1v v1v marked this pull request as ready for review June 6, 2025 07:37
@v1v v1v requested review from a team as code owners June 6, 2025 07:37
Copy link
Contributor

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM it's so great to see unnecessary scripts/files getting removed!

I also couldn't find any uses of google_cloud_auth() so it's great that it gets removed from both.

@v1v v1v merged commit c01278b into elastic:main Jun 10, 2025
14 checks passed
Copy link
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0

Copy link
Contributor

mergify bot commented Jun 10, 2025

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

@v1v
Copy link
Member Author

v1v commented Jun 10, 2025

@Mergifyio backport 9.0

Copy link
Contributor

mergify bot commented Jun 10, 2025

backport 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 10, 2025
v1v added a commit that referenced this pull request Jun 12, 2025
…ts-oblt-cli

* feature/serverless-its-oblt-cli: (51 commits)
  as agreed let's move the group to the kb.integration pipeline
  Update .github/workflows/serverless-project.yml
  ci: invoke serverless integration tests package from BK
  github-actions: create a serverless project daily
  [tests] split up serverless and resource leaks integration tests (#8396)
  chore: Update to elastic/beats@dfdc12e33de0 (#8446)
  Lock upgrade marker (#8254)
  build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420)
  Add docker image name template and renamed fips cloud specs (#8429)
  buildkite(scripts): refactor common scripts (#8365)
  Use require.Eventually to try and address flakiness (#8421)
  Fix pre-command to support extended testing (#8418)
  [Automation] Bump Golang version to 1.24.4 (#8384)
  chore: Update to elastic/beats@aed2a8b768bd (#8423)
  [main][Automation] Update versions (#8425)
  Add Pipeline to deploy custom agent image for FIPS testing (#8035)
  ci: automatically update OTel components (#8288)
  [Automation] Bump VM Image version to 1749258065 (#8390)
  fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374)
  otel: add cumulativetodeltaprocessor to EDOT collector (#8372)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants