fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault #8374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est_checkForUnprivilegedVault
pkoutsovasilis
added
Team:Elastic-Agent-Control-Plane
|
💚 Build Succeeded
|
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
ebeahan
approved these changes
Jun 6, 2025
|
@Mergifyio backport 8.17 8.18 8.19 9.0 |
✅ Backports have been created
|
8 tasks
8 tasks
8 tasks
8 tasks
michel-laterman
pushed a commit
to michel-laterman/elastic-agent
that referenced
this pull request
Jun 9, 2025
…est_checkForUnprivilegedVault (elastic#8374) * fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault * fix: SA1019 logp.NewInMemory is deprecated
v1v
added a commit
that referenced
this pull request
Jun 12, 2025
…ts-oblt-cli * feature/serverless-its-oblt-cli: (51 commits) as agreed let's move the group to the kb.integration pipeline Update .github/workflows/serverless-project.yml ci: invoke serverless integration tests package from BK github-actions: create a serverless project daily [tests] split up serverless and resource leaks integration tests (#8396) chore: Update to elastic/beats@dfdc12e33de0 (#8446) Lock upgrade marker (#8254) build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.12 to 0.11.13 (#8420) Add docker image name template and renamed fips cloud specs (#8429) buildkite(scripts): refactor common scripts (#8365) Use require.Eventually to try and address flakiness (#8421) Fix pre-command to support extended testing (#8418) [Automation] Bump Golang version to 1.24.4 (#8384) chore: Update to elastic/beats@aed2a8b768bd (#8423) [main][Automation] Update versions (#8425) Add Pipeline to deploy custom agent image for FIPS testing (#8035) ci: automatically update OTel components (#8288) [Automation] Bump VM Image version to 1749258065 (#8390) fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault (#8374) otel: add cumulativetodeltaprocessor to EDOT collector (#8372) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses increases the test context timeout from 5s to 20s of
Test_checkForUnprivilegedVaultto accommodate for slower machines, such as Mac CI runners, and to avoid intermittent failures due to timing out while trying to acquire a file lock.Why is it important?
The test
Test_checkForUnprivilegedVault/file_vault_exists_but_it's_unreadable_-_return_errorwas observed to fail intermittently on slower environments (e.g., Mac runners) due tocontext deadline exceedederrors when attempting to acquire a file lock. These failures were not related to the actual logic being tested, but rather to insufficient timeout settings. Increasing the timeout ensures test stability across environments. In addition, updating the deprecatedlogp.NewInMemorycall eliminates static analysis warnings.Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
None. This change only affects a unit test and does not impact production behavior or configurations.
How to test this PR locally
Related issues