Skip to content

Adding a unified FIPS integration test #8383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jun 6, 2025

What does this PR do?

This PR consolidates multiple FIPS-related integration tests into a single one. Specifically, this PR adds a new TestFIPS integration test and deletes the existing TestFIPSAgentConnectingToFIPSFleetServerInECHFRH and TestFleetManagedUpgradeUnprivilegedFIPS tests. This PR will also replace #8197 which was introducing the TestEnrollFIPS integration test.

Why is it important?

So we can get all FIPS-related integration test coverage without significantly increasing integration test run time due to multiple tests with overlapping coverage.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None; refactoring integration tests.


func upgradeFIPSAgent(t *testing.T, info *define.Info) {
t.Helper()
// TODO
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will flesh this out once #7804 is merged.

Copy link
Contributor

mergify bot commented Jun 6, 2025

This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Copy link
Contributor

mergify bot commented Jun 9, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b it-fips upstream/it-fips
git merge upstream/main
git push upstream it-fips

Copy link
Contributor

mergify bot commented Jun 10, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b it-fips upstream/it-fips
git merge upstream/main
git push upstream it-fips

@ycombinator ycombinator force-pushed the it-fips branch 2 times, most recently from e204459 to 80d62b6 Compare June 12, 2025 21:32
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 18, 2025

Copy link

Copy link
Contributor

mergify bot commented Jun 24, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b it-fips upstream/it-fips
git merge upstream/main
git push upstream it-fips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch skip-changelog Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants