-
Notifications
You must be signed in to change notification settings - Fork 176
Adding a unified FIPS integration test #8383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
testing/integration/fips_test.go
Outdated
|
||
func upgradeFIPSAgent(t *testing.T, info *define.Info) { | ||
t.Helper() | ||
// TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will flesh this out once #7804 is merged.
This pull request does not have a backport label. Could you fix it @ycombinator? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
This pull request is now in conflicts. Could you fix it? 🙏
|
e204459
to
80d62b6
Compare
💔 Build Failed
Failed CI Steps
History
cc @ycombinator |
|
This pull request is now in conflicts. Could you fix it? 🙏
|
What does this PR do?
This PR consolidates multiple FIPS-related integration tests into a single one. Specifically, this PR adds a new
TestFIPS
integration test and deletes the existingTestFIPSAgentConnectingToFIPSFleetServerInECHFRH
andTestFleetManagedUpgradeUnprivilegedFIPS
tests. This PR will also replace #8197 which was introducing theTestEnrollFIPS
integration test.Why is it important?
So we can get all FIPS-related integration test coverage without significantly increasing integration test run time due to multiple tests with overlapping coverage.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolDisruptive User Impact
None; refactoring integration tests.