[8.19] (backport #8374) fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault #8394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses increases the test context timeout from 5s to 20s of
Test_checkForUnprivilegedVault
to accommodate for slower machines, such as Mac CI runners, and to avoid intermittent failures due to timing out while trying to acquire a file lock.Why is it important?
The test
Test_checkForUnprivilegedVault/file_vault_exists_but_it's_unreadable_-_return_error
was observed to fail intermittently on slower environments (e.g., Mac runners) due tocontext deadline exceeded
errors when attempting to acquire a file lock. These failures were not related to the actual logic being tested, but rather to insufficient timeout settings. Increasing the timeout ensures test stability across environments. In addition, updating the deprecatedlogp.NewInMemory
call eliminates static analysis warnings.Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
None. This change only affects a unit test and does not impact production behavior or configurations.
How to test this PR locally
Related issues
This is an automatic backport of pull request fix: increase context timeout to accommodate for slower machines in Test_checkForUnprivilegedVault #8374 done by Mergify.