Skip to content

[8.18] (backport #8365) buildkite(scripts): refactor common scripts #8439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 10, 2025

What does this PR do?

  • Remove common2.sh
  • Remove unused function

Why is it important?

Tidy up the code and the usage:

  • common2.sh does not contain much logic, and some env variables are already created in the pre-command hook when it runs the common.sh script.
  • common2.sh name is not clear enough.
  • google_cloud_auth function is not actually called anywhere as far I can see at the GitHub search.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #8365 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jun 10, 2025
@mergify mergify bot requested review from a team as code owners June 10, 2025 14:30
@mergify mergify bot added the backport label Jun 10, 2025
@mergify mergify bot assigned v1v Jun 10, 2025
@v1v v1v enabled auto-merge (squash) June 10, 2025 14:49
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@v1v v1v merged commit a6fd337 into 8.18 Jun 10, 2025
13 checks passed
@v1v v1v deleted the mergify/bp/8.18/pr-8365 branch June 10, 2025 16:24
@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @v1v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants