Skip to content

[8.17] (backport #8084) ci(test): skip skipped tests from the Test JUnit output #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 12, 2025

What does this PR do?

Bump the gotestsum version and eemove skipped tests from the aggregated report.

Why is it important?

The integration tests reporting have a few non-critical reporting issues:

  • Each test step has its own XML and HTML report in atrifacts (Build example)
  • The reports contain many of skipped tests (example)

That affects:

  • General test report readability
  • Buildkite Test Suites show wrong AVG duration and failure percentage

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Run make and then .

I compared this test-result from main vs this PR

image

vs

image

Related issues

gotestyourself/gotestsum#478 has been merged and https://github.com/gotestyourself/gotestsum/releases/tag/v1.12.2 has been released

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #8084 done by [Mergify](https://mergify.com).

(cherry picked from commit 05289da)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh
#	.buildkite/scripts/integration-tests.ps1
#	go.mod
#	go.sum
@mergify mergify bot requested a review from a team as a code owner June 12, 2025 05:52
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 12, 2025
@mergify mergify bot requested a review from a team as a code owner June 12, 2025 05:52
@mergify mergify bot requested review from swiatekm and pchila and removed request for a team June 12, 2025 05:52
@mergify mergify bot assigned v1v Jun 12, 2025
Copy link
Contributor Author

mergify bot commented Jun 12, 2025

Cherry-pick of 05289da has failed:

On branch mergify/bp/8.17/pr-8084
Your branch is up to date with 'origin/8.17'.

You are currently cherry-picking commit 05289da6b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/scripts/buildkite-k8s-integration-tests.sh
	modified:   Makefile
	modified:   dev-tools/mage/gotest.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/scripts/buildkite-integration-tests.sh
	both modified:   .buildkite/scripts/integration-tests.ps1
	both modified:   go.mod
	both modified:   go.sum

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@elasticmachine
Copy link
Collaborator

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @v1v

@v1v v1v removed the conflicts There is a conflict in the backported pull request label Jun 12, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit ef46c35 into 8.17 Jun 12, 2025
12 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.17/pr-8084 branch June 12, 2025 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants