Disable microsoft/go build telemetry

[michel-laterman]

What does this PR do?

Disable microsoft/go build telemetry in the spec and magefile.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[simitt]

@pchila could you give this a review also please, as I believe you are the most familiar with the Elastic Agent build parts and it is important to always opt out.

[pchila]

Adding MS_GOTOOLCHAIN_TELEMETRY_ENABLED env var in the fips settings should be enough to pass it to golang-crossbuild when building the elastic-agent binary.

I wonder if this is needed also when running fips unit tests as I think that the microsoft/go runtime is used there as well. @michel-laterman could you please check ?

[ycombinator]

Shouldn't we also check for MS_GOTOOLCHAIN_TELEMETRY_ENABLED in here?

elastic-agent/dev-tools/packaging/testing/package_test.go

Lines 804 to 821 in ac9ee9a

	foundTags := false
	foundExperiment := false
	for _, setting := range info.Settings {
	switch setting.Key {
	case "-tags":
	foundTags = true
	require.Contains(t, setting.Value, "requirefips")
	require.Contains(t, setting.Value, "ms_tls13kdf")
	continue
	case "GOEXPERIMENT":
	foundExperiment = true
	require.Contains(t, setting.Value, "systemcrypto")
	continue
	}
	}
	require.True(t, foundTags, "Did not find -tags within binary version information")
	require.True(t, foundExperiment, "Did not find GOEXPERIMENT within binary version information")

[michel-laterman]

I don't think we need to check for the MS toolchain var in the binary; the var controls what the go binary does, not what we produce

[v1v]

Shall we consider using the pre-command hook instead? I'm not a big fan of the pre-command hook, but I feel enabling that env variable everywhere by default could be helpful. WDYT?

[michel-laterman]

I think that having it in the fips bk pipeline is much clearer then using a hook

[v1v]

LGTM, Could the environment variable be defined at the beginning of the env section? Instead of the step itself?

[michel-laterman]

buildkite test this

[michel-laterman]

buildkite test this

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[elasticmachine]

💛 Build succeeded, but was flaky

• Buildkite Build
• Commit: 9f81d86

Failed CI Steps

• fips:x86_64:sudo-false:fleet

History

• 💔 Build #22722 failed 9f81d86
• 💔 Build #22697 failed 9f81d86
• 💔 Build #22643 failed a8bb71f
• 💔 Build #22625 failed 49d9213
• 💔 Build #22345 failed 2936f64

cc @michel-laterman