-
Notifications
You must be signed in to change notification settings - Fork 176
[8.18](backport #7995) Enable Filebeat's Journald input in some docker image variants #8482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Filebeat's Journald input requires `journalctl`, so the systemd package is added to elastic-agent, elastic-agent-complete, elastic-otel-collector variants. --------- Co-authored-by: Craig MacKenzie <craig.mackenzie@elastic.co> (cherry picked from commit fd33d85) # Conflicts: # dev-tools/packaging/settings.go # dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl
Cherry-pick of fd33d85 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Mostly re-doing the addition of systemd packages due to the different base images
This pull request has not been merged yet. Could you please review and merge it @belimawr? 🙏 |
ok the ugprade failures are known and being handled in the beats repo. but @belimawr have a look at the changes I did and merge it if you are ok 🙂 |
Be my guest :D. Thanks for the help! I had seen #8452, hence I was considering this PR blocked until it was solved, I should have linked it here. Sorry for that. |
I removed myself from the assignee list, but feel free to ping me if you need anything. |
changelog/fragments/1745609163-journalctl-on-all-docker-variants.yaml
Outdated
Show resolved
Hide resolved
|
💛 Build succeeded, but was flaky
Failed CI Steps
History
|
What does this PR do?
Filebeat's Journald input requires
journalctl
, so the systemd package is added to all docker image variants.Changes in image size
Images built from
main
(f108618):Images built from this PR:
Increase in size
docker.elastic.co/elastic-agent/elastic-agent-complete
: 10MBdocker.elastic.co/elastic-agent/elastic-otel-collector
: 50MBdocker.elastic.co/elastic-agent/elastic-agent
: 40MBWhy is it important?
Currently it is only possible to use integrations that requires the journald input with the complete docker image variant, this PR allows it to be used with any docker image variant. The complete docker image is the largest with more than 3Gb, while the standard Elastic-Agent image is less than 2Gb.
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog toolI have added an integration test or an E2E test## Disruptive User ImpactAuthor's Checklist
How to test this PR locally
journalctl
on each docker image by running the following script/commands:Related issues
journalctl
to Filebeat and Elastic-Agent docker images beats#44040Questions to ask yourself
This is an automatic backport of pull request #7995 done by [Mergify](https://mergify.com).