Skip to content

[9.0] (backport #8359) updatecli: create PRs per active branch and refactor slack notifications #8508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 15, 2025

What does this PR do?

  • Run on Saturdays, a few hours after VM images are produced.
  • Create PRs per active branch instead of using the backport labels.
  • Use slack composite action.
  • Notify the robots team if something goes wrong with the GH actions.
  • Enable auto approval and auto-merge with Mergify [Need to configure the branch protections accordingly]

Why is it important?

A follow-up from #8211

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

$ GITHUB_TOKEN=$(gh auth token) \
  GITHUB_ACTOR=v1v \
  BRANCH_NAME=main updatecli apply \
    --config .ci/updatecli/updatecli-bump-vm-images.yml \
    --values .ci/updatecli/values.d/scm.yml

Produced v1v#7

Then I targeted a different branch

$ GITHUB_TOKEN=$(gh auth token) \
  GITHUB_ACTOR=v1v \
  BRANCH_NAME=main updatecli apply \
    --config .ci/updatecli/updatecli-bump-vm-images.yml \
    --values .ci/updatecli/values.d/scm.yml

Produced v1v#8

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #8359 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Jun 15, 2025
@mergify mergify bot requested review from a team as code owners June 15, 2025 19:01
@mergify mergify bot added the backport label Jun 15, 2025
@mergify mergify bot assigned v1v Jun 15, 2025
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team June 15, 2025 19:01
@v1v v1v enabled auto-merge (squash) June 15, 2025 19:02
@v1v v1v disabled auto-merge June 15, 2025 19:31
@v1v v1v merged commit 918c92f into 9.0 Jun 15, 2025
10 checks passed
@v1v v1v deleted the mergify/bp/9.0/pr-8359 branch June 15, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant