-
Notifications
You must be signed in to change notification settings - Fork 176
[8.17] (backport #8359) updatecli: create PRs per active branch and refactor slack notifications #8509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I somehow thought that However, it's still pending ![]() For instance, I've seen it work fine for #8312: ![]() Now, what's the reason |
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
1 similar comment
This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@v1v re your previous comment, after clicking update branch, there was a rerun which now shows the green tick box in ![]() Even though it's a green tick box, it seems it's not sufficient for automerge and the requirement for Is this something we'll always need to do going forwards? |
This pull request is now in conflicts. Could you fix it? 🙏
|
051dbdd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM fixed a merge conflict after 0cff839
I'm still figuring out what the path forward is - when I enabled the mergify auto-merge, I think there was some condition that worked as expected: That mistakenly made me think things were good to move forward. |
What does this PR do?
Mergify
[Need to configure the branch protections accordingly]Why is it important?
A follow-up from #8211
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
$ GITHUB_TOKEN=$(gh auth token) \ GITHUB_ACTOR=v1v \ BRANCH_NAME=main updatecli apply \ --config .ci/updatecli/updatecli-bump-vm-images.yml \ --values .ci/updatecli/values.d/scm.yml
Produced v1v#7
Then I targeted a different branch
$ GITHUB_TOKEN=$(gh auth token) \ GITHUB_ACTOR=v1v \ BRANCH_NAME=main updatecli apply \ --config .ci/updatecli/updatecli-bump-vm-images.yml \ --values .ci/updatecli/values.d/scm.yml
Produced v1v#8
Related issues
Questions to ask yourself
This is an automatic backport of pull request #8359 done by [Mergify](https://mergify.com).