Skip to content

[CI] Add exclusions for release branches #8542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

Conversation

pazone
Copy link
Collaborator

@pazone pazone commented Jun 16, 2025

What does this PR do?

UpdateCLI ESS version pinning: Adds exclusions for release branches because we decided to merge them later.
The exclusions must be removed when the backports are merged
Fixes a typo in pipeline name

Why is it important?

Fixes a regression #8352

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added the enhancement New feature or request label Jun 16, 2025
@pazone pazone requested a review from a team as a code owner June 16, 2025 16:37
@pazone pazone requested a review from a team as a code owner June 16, 2025 16:37
@mergify mergify bot assigned pazone Jun 16, 2025
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I ran https://github.com/elastic/elastic-agent/actions/runs/15686671952 but it will fail as the fix is not in main yet, but the exclude branches should work.

However, can you run the updatecli command to validate if your changes are good? That's something we have done in some other PRs:

Thanks

@v1v v1v self-requested a review June 16, 2025 16:43
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, the GH workflow for this feature branch, worked as expected and created #8543

@pazone pazone merged commit d8e3c17 into main Jun 16, 2025
14 checks passed
@pazone pazone deleted the ci_fix_updatecli_ess_pinning branch June 16, 2025 16:53
@v1v v1v added bug Something isn't working and removed enhancement New feature or request labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants