Skip to content

[Data Management]Add static factoryNumber in SnifferThreadFactory #101871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Data Management]Add static factoryNumber in SnifferThreadFactory #101871

wants to merge 1 commit into from

Conversation

HoitZzang
Copy link

related issue #78271

Motivation:

// SnifferThreadFactory 1
es_rest_client_sniffer[T1],
es_rest_client_sniffer[T2],
es_rest_client_sniffer[T3] ..

// SnifferThreadFactory 2
es_rest_client_sniffer[T1],
es_rest_client_sniffer[T2],
es_rest_client_sniffer[T3] .. // same thread name with Factory 1

Modification:

// SnifferThreadFactory 1
es_rest_client_sniffer[F1,T1],
es_rest_client_sniffer[F1,T2],
es_rest_client_sniffer[F1,T3] ..

// SnifferThreadFactory 2
es_rest_client_sniffer[F2,T1],
es_rest_client_sniffer[F2,T2],
es_rest_client_sniffer[F2,T3] ..
  • Add factoryNumber on SnifferThreadFactory to set different thread name that created from different factory

Result:

@elasticsearchmachine elasticsearchmachine added v8.12.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Nov 7, 2023
@HoitZzang HoitZzang force-pushed the feat-addSnifferThread-78271 branch from 411432b to 30ff9eb Compare November 7, 2023 12:16
@gbanasiak gbanasiak added the Team:Data Management Meta label for data/management team label Nov 23, 2023
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management Meta label for data/management team label Nov 23, 2023
@elasticsearchmachine elasticsearchmachine added Team:Clients Meta label for clients team and removed needs:triage Requires assignment of a team area label labels Nov 23, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/clients-team (Team:Clients)

@dakrone dakrone added :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch and removed :Clients/Java High Level REST Client labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Clients Meta label for clients team v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add static attribute for threadNumber in SnifferThreadFactory
6 participants
@HoitZzang @elasticsearchmachine @dakrone @brianseeders @mark-vieira @gbanasiak