Skip to content

Remove doPrivileged from plugins #127996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented May 9, 2025

This commit continues the work of removing SecurityManager related code by removing doPrivileged calls from Elasticsearch plugins.

This commit continues the work of removing SecurityManager related code
by removing doPrivileged calls from Elasticsearch plugins.
@rjernst rjernst requested a review from a team May 9, 2025 18:54
@rjernst rjernst added >refactoring auto-backport Automatically create backport pull requests when merged v8.19.0 v9.1.0 :Core/Infra/Entitlements Entitlements infrastructure labels May 9, 2025
@rjernst
Copy link
Member Author

rjernst commented May 9, 2025

This again touches mostly cloud discovery plugins, so asking distrib for review.

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 9, 2025
@DaveCTurner
Copy link
Contributor

Distrib changes all look ok, but I'm not so sure about the Hadoop stuff. In practice it's @elastic/es-data-management who have the expertise in this area. Could you pull that out into a separate PR for them to take a look?

@rjernst
Copy link
Member Author

rjernst commented May 12, 2025

@jbaiera can you take a look? happy to split out the hadoop stuff

Copy link
Member

@masseyke masseyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HDFS-related changes look fine to me.

@rjernst rjernst merged commit 79d3aa8 into elastic:main May 21, 2025
17 checks passed
@rjernst rjernst deleted the sm/remove_do_priv_plugins branch May 21, 2025 16:00
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 21, 2025
This commit continues the work of removing SecurityManager related code
by removing doPrivileged calls from Elasticsearch plugins.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19

elasticsearchmachine pushed a commit that referenced this pull request May 21, 2025
This commit continues the work of removing SecurityManager related code
by removing doPrivileged calls from Elasticsearch plugins.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure >refactoring Team:Core/Infra Meta label for core/infra team v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants