Skip to content

Reapply "Adds unused lower level ivf knn query (#127852)" (#128003) #128052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2025
Merged

Reapply "Adds unused lower level ivf knn query (#127852)" (#128003) #128052

merged 2 commits into from
May 14, 2025

Conversation

benwtrent
Copy link
Member

reapplies reversion. This also contains a test fix where we would periodically set numVectorsPerCluster to 0, which is disallowed.

closes: #127963
closes: #127941
closes: #127969
closes: #128002

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label May 13, 2025
john-wagster
john-wagster approved these changes May 13, 2025
View reviewed changes
Copy link
Contributor

@john-wagster john-wagster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benwtrent benwtrent merged commit 85f4662 into elastic:main May 14, 2025
17 checks passed
@benwtrent benwtrent deleted the ivf-query-2 branch May 14, 2025 15:18
richard-dennehy pushed a commit to richard-dennehy/elasticsearch that referenced this pull request May 19, 2025
@benwtrent @richard-dennehy
Reapply "Adds unused lower level ivf knn query (elastic#127852)" (ela…
de7d06c 
…stic#128003) (elastic#128052)

* Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003)

This reverts commit 648d74b.

* Fixing tests
benchaplin pushed a commit to benchaplin/elasticsearch that referenced this pull request May 20, 2025
@benwtrent @benchaplin
Reapply "Adds unused lower level ivf knn query (elastic#127852)" (ela…
5886ec8 
…stic#128003) (elastic#128052)

* Reapply "Adds unused lower level ivf knn query (elastic#127852)" (elastic#128003)

This reverts commit 648d74b.

* Fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-wagster john-wagster

Assignees
No one assigned
Labels
>non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0
Projects
None yet
Milestone
No milestone
3 participants
@benwtrent @elasticsearchmachine @john-wagster