[Entitlements] Add test entitlement bootstrap and initialization classes #128625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntitlements-bootstrap-2
…ntitlements-bootstrap-2
…ntitlements-bootstrap-2
…ntitlements-bootstrap-2
prdoyle
added
auto-backport
prdoyle
changed the title
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jdconrad
approved these changes
May 29, 2025
| * Activates entitlement checking in tests. | ||
| * @param bootstrapArgs arguments used for and passed to entitlement initialization | ||
| */ | ||
| public static void bootstrap(BootstrapArgs bootstrapArgs) { |
There was a problem hiding this comment.
I thought we were going to rename BootstrapArgs to InitializationArgs or something like that?
There was a problem hiding this comment.
Actually, since this moves a class completely instead of just a simple rename, let's do this in a follow up pr.
There was a problem hiding this comment.
Yep, that's coming right up! I'm planning to encapsulate BootstrapArgs and PathResolver in the next PR.
rjernst
approved these changes
May 29, 2025
| * @return the plugin info | ||
| * @throws IOException if an I/O exception occurred reading the plugin descriptor | ||
| */ | ||
| public static PluginDescriptor readInternalDescriptor(InputStream stream) throws IOException { |
There was a problem hiding this comment.
nit: readFromStream to match readFromProperties above?
There was a problem hiding this comment.
I think this does less than readFromProperties: it does not support stable plugins.
I can go with readInternalDescriptorFromStream if that's better.
...rc/main/java/org/elasticsearch/entitlement/initialization/TestEntitlementInitialization.java
Outdated
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
prdoyle
added a commit
to prdoyle/elasticsearch
that referenced
this pull request
May 30, 2025
…ses (elastic#128625) * Initialization class as argument to EntitlementAgent * visibility changes * WIP: test entitlement bootstrap and initialization classes * Simplify * Moving packages to reduce visibility * adjust visibility * add plugins descriptor + policy parsing * PR comments * update visibility, uncomment TestBuildInfoParser usage * [CI] Auto commit changes from spotless * Factor out createPolicyManager to help merge * TestEntitlementInitialization is not yet implemented * Respond to PR comments --------- Co-authored-by: Lorenzo Dematte <lorenzo.dematte@elastic.co> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
|
Backporting to 8.19 in #128691 |
elasticsearchmachine
added a commit
that referenced
this pull request
May 30, 2025
…8691) * Inline call to getVersionSpecificCheckerClass. This makes the code a smidge more like main to ease the backport * [Entitlements] Add test entitlement bootstrap and initialization classes (#128625) * Initialization class as argument to EntitlementAgent * visibility changes * WIP: test entitlement bootstrap and initialization classes * Simplify * Moving packages to reduce visibility * adjust visibility * add plugins descriptor + policy parsing * PR comments * update visibility, uncomment TestBuildInfoParser usage * [CI] Auto commit changes from spotless * Factor out createPolicyManager to help merge * TestEntitlementInitialization is not yet implemented * Respond to PR comments --------- Co-authored-by: Lorenzo Dematte <lorenzo.dematte@elastic.co> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co> --------- Co-authored-by: Lorenzo Dematte <lorenzo.dematte@elastic.co> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…ses (elastic#128625) * Initialization class as argument to EntitlementAgent * visibility changes * WIP: test entitlement bootstrap and initialization classes * Simplify * Moving packages to reduce visibility * adjust visibility * add plugins descriptor + policy parsing * PR comments * update visibility, uncomment TestBuildInfoParser usage * [CI] Auto commit changes from spotless * Factor out createPolicyManager to help merge * TestEntitlementInitialization is not yet implemented * Respond to PR comments --------- Co-authored-by: Lorenzo Dematte <lorenzo.dematte@elastic.co> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…ses (elastic#128625) * Initialization class as argument to EntitlementAgent * visibility changes * WIP: test entitlement bootstrap and initialization classes * Simplify * Moving packages to reduce visibility * adjust visibility * add plugins descriptor + policy parsing * PR comments * update visibility, uncomment TestBuildInfoParser usage * [CI] Auto commit changes from spotless * Factor out createPolicyManager to help merge * TestEntitlementInitialization is not yet implemented * Respond to PR comments --------- Co-authored-by: Lorenzo Dematte <lorenzo.dematte@elastic.co> Co-authored-by: elasticsearchmachine <infra-root+elasticsearchmachine@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entitlement bootstrap and initialization for tests.
It loads the agent, use the TestBuildInfo files to create a test ScopeResolver and to locate and load policies and descriptors for plugins and server.
To be used in
BootstrapForTesting.(Continuation of #127814, merged with main, and including some tweaks we discussed.)