-
Notifications
You must be signed in to change notification settings - Fork 8.4k
[Infra] Improve the waffle map date picker dismissal code #224095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Improve the waffle map date picker dismissal code #224095
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8380[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed. |
@@ -30,8 +30,7 @@ export function InfraHomePageProvider({ getService, getPageObjects }: FtrProvide | |||
await datePickerInput.clearValueWithKeyboard(); | |||
await datePickerInput.type(time); | |||
|
|||
// dismiss the tooltip, which won't be hidden because blur doesn't happen reliably | |||
await this.dismissDatePickerTooltip(); | |||
datePickerInput.pressKeys(browser.keys.ESCAPE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pressing ESC closes the modal.
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8382[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed. |
b37b9b1
to
53a2b78
Compare
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#8396[❌] x-pack/test/functional/apps/infra/config.ts: 0/25 tests passed. |
53a2b78
to
1a7ec9e
Compare
1a7ec9e
to
9b791a8
Compare
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#8401[✅] x-pack/test/functional/apps/infra/config.ts: 25/25 tests passed. |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
) (#226199) # Backport This will backport the following commits from `main` to `9.1`: - [[Infra] Improve the waffle map date picker dismissal code (#224095)](#224095) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T12:43:45Z","message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"[Infra] Improve the waffle map date picker dismissal code","number":224095,"url":"https://github.com/elastic/kibana/pull/224095","mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224095","number":224095,"mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
…4095) (#226194) # Backport This will backport the following commits from `main` to `8.18`: - [[Infra] Improve the waffle map date picker dismissal code (#224095)](#224095) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T12:43:45Z","message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"[Infra] Improve the waffle map date picker dismissal code","number":224095,"url":"https://github.com/elastic/kibana/pull/224095","mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224095","number":224095,"mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 |
) (#226198) # Backport This will backport the following commits from `main` to `9.0`: - [[Infra] Improve the waffle map date picker dismissal code (#224095)](#224095) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T12:43:45Z","message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"[Infra] Improve the waffle map date picker dismissal code","number":224095,"url":"https://github.com/elastic/kibana/pull/224095","mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224095","number":224095,"mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 |
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
…4095) (#226192) # Backport This will backport the following commits from `main` to `8.17`: - [[Infra] Improve the waffle map date picker dismissal code (#224095)](#224095) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"crespocarlos@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-07-02T12:43:45Z","message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63","branchLabelMapping":{"^v9.2.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-infra_services","backport:version","v8.17.0","v8.18.0","v9.1.0","v8.19.0","v9.2.0"],"title":"[Infra] Improve the waffle map date picker dismissal code","number":224095,"url":"https://github.com/elastic/kibana/pull/224095","mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.17","8.18","9.1","8.19"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.2.0","branchLabelMappingKey":"^v9.2.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224095","number":224095,"mergeCommit":{"message":"[Infra] Improve the waffle map date picker dismissal code (#224095)\n\nfixes [135000](https://github.com/elastic/kibana/issues/135000)\n\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>\nCo-authored-by: jennypavlova <dzheni.pavlova@elastic.co>","sha":"82c462ca72fe6a792c3db5ebc0088331551eaa63"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <crespocarlos@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
Starting backport for target branches: 8.17, 8.18, 8.19, 9.0, 9.1 |
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co> (cherry picked from commit 82c462c)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…4095) fixes [135000](elastic#135000) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: jennypavlova <dzheni.pavlova@elastic.co>
fixes 135000