Skip to content

[ML] Trained Models: Hides Adaptive Allocations Toggle in Serverless #224097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Jun 16, 2025

Resolves #221894
Removes the adaptive allocations toggle in serverless (always enabled).
Adjusts the min_allocations param:

  • Observability - min: 0
  • Search - min: 0
  • Security - min: 1

@rbrtj rbrtj self-assigned this Jun 16, 2025
@rbrtj rbrtj added release_note:fix :ml backport:skip This commit does not require backporting Team:ML Team label for ML (also use :ml) v9.1.0 labels Jun 16, 2025
@rbrtj rbrtj marked this pull request as ready for review June 16, 2025 15:58
@rbrtj rbrtj requested review from a team as code owners June 16, 2025 15:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elena-shostak elena-shostak self-requested a review June 17, 2025 10:33
@rbrtj rbrtj requested a review from darnautov June 17, 2025 14:51
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / Entity Analytics - Entity Store @ess Host transform logic Install Entity Store and test Host transform "before each" hook for "Should successfully trigger a host transform"

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 5.4MB 5.4MB +24.0B

History

cc @rbrtj

@rbrtj rbrtj added backport:version Backport to applied version labels and removed backport:skip This commit does not require backporting labels Jun 18, 2025
@rbrtj rbrtj added the v8.19.0 label Jun 18, 2025
@rbrtj rbrtj merged commit f79b68d into elastic:main Jun 18, 2025
15 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.19

https://github.com/elastic/kibana/actions/runs/15734768717

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 18, 2025
…lastic#224097)

Resolves elastic#221894
Removes the adaptive allocations toggle in serverless (always enabled).
Adjusts the `min_allocations` param:
* Observability - min: 0
* Search - min: 0
* Security - min: 1

(cherry picked from commit f79b68d)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.19

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jun 18, 2025
…rless (#224097) (#224433)

# Backport

This will backport the following commits from `main` to `8.19`:
- [[ML] Trained Models: Hide Adaptive Allocations Toggle in Serverless
(#224097)](#224097)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"92210485+rbrtj@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-06-18T13:52:15Z","message":"[ML]
Trained Models: Hide Adaptive Allocations Toggle in Serverless
(#224097)\n\nResolves
https://github.com/elastic/kibana/issues/221894\nRemoves the adaptive
allocations toggle in serverless (always enabled).\nAdjusts the
`min_allocations` param:\n* Observability - min: 0\n* Search - min: 0\n*
Security - min:
1","sha":"f79b68d84eccd6d01c93bcd1f0fe617cfa549459","branchLabelMapping":{"^v9.1.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","Team:ML","backport:version","v9.1.0","v8.19.0"],"title":"[ML]
Trained Models: Hide Adaptive Allocations Toggle in
Serverless","number":224097,"url":"https://github.com/elastic/kibana/pull/224097","mergeCommit":{"message":"[ML]
Trained Models: Hide Adaptive Allocations Toggle in Serverless
(#224097)\n\nResolves
https://github.com/elastic/kibana/issues/221894\nRemoves the adaptive
allocations toggle in serverless (always enabled).\nAdjusts the
`min_allocations` param:\n* Observability - min: 0\n* Search - min: 0\n*
Security - min:
1","sha":"f79b68d84eccd6d01c93bcd1f0fe617cfa549459"}},"sourceBranch":"main","suggestedTargetBranches":["8.19"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/224097","number":224097,"mergeCommit":{"message":"[ML]
Trained Models: Hide Adaptive Allocations Toggle in Serverless
(#224097)\n\nResolves
https://github.com/elastic/kibana/issues/221894\nRemoves the adaptive
allocations toggle in serverless (always enabled).\nAdjusts the
`min_allocations` param:\n* Observability - min: 0\n* Search - min: 0\n*
Security - min:
1","sha":"f79b68d84eccd6d01c93bcd1f0fe617cfa549459"}},{"branch":"8.19","label":"v8.19.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <92210485+rbrtj@users.noreply.github.com>
@nastasha-solomon nastasha-solomon changed the title [ML] Trained Models: Hide Adaptive Allocations Toggle in Serverless [ML] Trained Models: Hides Adaptive Allocations Toggle in Serverless Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels :ml release_note:enhancement Team:ML Team label for ML (also use :ml) v8.19.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Trained models: Hide adaptive allocations UX in start deployment modal for serverless
8 participants