[8.19] [Obs AI Assistant] Anonymization support (#223351) #224100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-submit of elastic#216352 as it has merge conflicts and we don't have write permissions for Sandra's remote. To test, add the following to your kibana.yml: ``` uiSettings: overrides: "observability:aiAssistantAnonymizationRules": - id: "ner" type: "ner" enabled: true - id: "beach" type: "regex" enabled: true pattern: "sandy" ``` --------- Co-authored-by: Sandra Gonzales <sandra.gonzales@elastic.co> Co-authored-by: Sandra G <neptunian@users.noreply.github.com> (cherry picked from commit 71ec37a) # Conflicts: # x-pack/platform/packages/shared/kbn-ai-assistant/src/chat/chat_timeline.tsx # x-pack/platform/plugins/shared/observability_ai_assistant/server/service/client/index.ts
|
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
neptunian
force-pushed
the
backport/8.19/pr-223351
branch
from
ecb5e38 to
8dd1022
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
History
|
viduni94
approved these changes
Jun 16, 2025
| @@ -27,7 +27,19 @@ import { ChatItemActions } from './chat_item_actions'; | |||
| import { ChatItemAvatar } from './chat_item_avatar'; | |||
| import { ChatItemContentInlinePromptEditor } from './chat_item_content_inline_prompt_editor'; | |||
| import { ChatTimelineItem } from './chat_timeline'; | |||
|
|
|||
| // Helper function to extract plain text from a React node. | |||
There was a problem hiding this comment.
Suggested change
| // Helper function to extract plain text from a React node. | |
| // Helper function to extract plain text from a React node. |
| return extractTextFromReactNode(node.props.children); | ||
| } | ||
| return ''; | ||
| } |
| parts.push(content.substring(lastIndex)); | ||
| } | ||
| return parts; | ||
| } |
| import { DetectedEntity } from '../../types'; | ||
| /** Regex matching object‑hash placeholders (40 hex chars) */ | ||
| export const HASH_REGEX = /[0-9a-f]{40}/g; | ||
| /** |
| }) | ||
| from(this.dependencies.anonymizationService.redactMessages(messages)).pipe( | ||
| switchMap(({ redactedMessages }) => { | ||
| this.dependencies.logger.debug( |
There was a problem hiding this comment.
We can remove this debug line I think as it's the same as the debug line in L496
|
|
||
| return redacted; | ||
| } | ||
| /** |
| @@ -35,7 +35,16 @@ export type ChatCompletionMessageEvent<TToolOptions extends ToolOptions = ToolOp | |||
| toolCalls: ToolCallsOf<TToolOptions>['toolCalls']; | |||
| } | |||
| >; | |||
|
|
|||
| // with unredactions | |||
There was a problem hiding this comment.
Suggested change
| // with unredactions | |
| // with unredactions |
| class_name: string; | ||
| hash: string; | ||
| }>; | ||
| } |
| } | ||
| return { unredactedMessages: messages }; | ||
| } | ||
| unredactChatCompletionEvent(): OperatorFunction< |
There was a problem hiding this comment.
Suggested change
| unredactChatCompletionEvent(): OperatorFunction< | |
| unredactChatCompletionEvent(): OperatorFunction< |
| content: message.message.content, | ||
| }; | ||
| } | ||
| export function getRedactableMessageEventParts(event: ChatCompletionMessageEvent) { |
There was a problem hiding this comment.
Suggested change
| export function getRedactableMessageEventParts(event: ChatCompletionMessageEvent) { | |
| export function getRedactableMessageEventParts(event: ChatCompletionMessageEvent) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.19:Questions ?
Please refer to the Backport tool documentation